#49626 Issue 49581 - Fix dynamic plugins test suite
Closed by spichugi. Opened by spichugi.
spichugi/389-ds-base dynamic_plugins  into  master

Download 49626.patch

Description: Refactor plugins module and fix tests accordingly.
Add absent Task and Plugin objects. Add docstrings for every
fixed object.

https://pagure.io/389-ds-base/issue/49581

Reviewed by: ?

rebased onto a817f1bf747684b25d57abc01b19ab8d132b8087

rebased onto 82eb986c1d3b77c16b3415eecb3a7e0e18d229a1

rebased onto 0cd4007191ad537c6519596f853f77c0bc6ad1c8

1 new commit added

  • Move plugin acceptance tests to a separate module in plugins suite

2 new commits added

  • Move plugin acceptance tests to a separate module in plugins suite
  • Issue 49581 - Fix dynamic plugins test suite

rebased onto 9c7a76e27adfff02c40abdd4d49acfa187b97a14

Shouldn't we be doing this through a referint plugin object instead?

Is there a need to use extensible object here?

rebased onto 6503cb48f1235b36e417dfd7e9d0bd214ae0a6d7

Thanks! I fixed it. The changes in the last commit.

Great, looks good. I'll let one of the others check too? Maybe @mreynolds. I haven't run these tests so it would be good for someone else to actually give the branch a go. :)

Passes for me

rebased onto 7fb2df5ae12835840a8c92ef3923c1f62b596344

rebased onto 3c2c2101b89ca79902eadec96c9ac4d27d8a1163

rebased onto dc7f1083c57da4a8826fd9ec36a4b7063a1bd4a6

Pull-Request has been merged by spichugi

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2685

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi

Metadata