389-ds-base

#49621 Ticket 46918 - Fix compiler warnings on arm
Closed by spichugi. Opened by mreynolds.
mreynolds/389-ds-base ticket49618  into  master

Download 49621.patch

Description: On "arm" architecture there were many compiler warnings
and after fixing some it also addressed a crash in replication
when trying to update the agreement maxcsn.

          All upstream architectures build without compiler warnings,
          and coverity scan did not report any regressions.

https://pagure.io/389-ds-base/issue/49618

Reviewed by: ?

/rebuild

I am not sure if I understand why it was changed?
If it is not a mistake, then we have the same line in bpt_cow.c:
src/libsds/sds/bpt_cow/bpt_cow.c:569: char *path = malloc(sizeof(char) * 20);

Typos in the commit massage:
" All updatream acrhcituctures ".

Besides that, the change looks good to me.

Ack from me too. Looks good.

@mreynolds @spichugi This has been acked, can we rebase and merge :)

Pull-Request has been closed by mreynolds

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2680

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.