389-ds-base

#49556 Issue 49278 - Add a new CI test case
Closed by spichugi. Opened by aadhikari.
aadhikari/389-ds-base get_effect_rights  into  master

Download 49556.patch

Bug Description: GetEffectiveRights gives false-negative with ACIs containing targetfilter

Fix Description: Added tests cases that will check whether a user have entry-level-access
even where the access is conditional on a targetfilter.
An non-existing entry defined by objectclass has effective rights.

https://pagure.io/389-ds-base/issue/49278

Reviewed by: ?

/rebuild

/rebuild

/rebuild

rebased onto e832423c9064f4abd72e41dca5c4b41850398dda

/rebuild

the test case is ok, but you should just use teh same user as in the previous test case. The issue is not that the user exists or does not exist, but if the entry GER is requested exists or not

I would add another test requestin g GER with a template trigger sn@inetuser and show that the user does not have access to this entry

xxx

the test case is basically goog, but I have two comments:

  • the difference of the tests is not if the user requesting GER for exists or not, but if the entry GER is applied to exists or not. So both test should be doen with the same user.

  • in the second test I would add another search with another GER request which triggers creation of a template where the user does not have access eg cn@groupofnames

@lkrispen Thank you so much for taking out time and helping us out here, I will do the changes ASAP.

rebased onto 3d2cb708b69c0b9269d5883ac008cc5ed817858d

rebased onto af3677f94beefaedfed9d364dc75babbc03e93fd

Looks good to me. Please, update commit message (Reviewed by part).
And rebase the branch with master.

We can merge it after that if @lkrispen is okay with that.

I am

rebased onto a65e6da68906d74e9dba33477fdd6c075d920914

Pull-Request has been merged by spichugi

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This pull request has been cloned to Github as issue and is available here:
- https://github.com/389ds/389-ds-base/issues/2615

If you want to continue to work on the PR, please navigate to the github issue,
download the patch from the attachments and file a new pull request.

Thank you for understanding. We apologize for all inconvenience.

Pull-Request has been closed by spichugi
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.