In the review for 49562 Thierry asked not to use "changelog.db" but some macros for the file name and the extension. This sounds reasonable, but is not that trivial. The places the filename is used are in dbscan, in repl plugin and in the backend. The do not "know" of each other, no common include to define the name in one place.
Especially dbscan is "outside" the server cods, it even contains copies of functions to parse CL entries. And it is one place changelog.db is used, so changing it by using a defien doesn't make a real difference.
Remains the usage in bdb_layer and cl5_init. It could be done to independently define the NAME.EXTENSION in these places, and keep them consistent. But ".db" is BDB specific, it should no longer be seen in cl5_init after the backend isolation is completed.
My suggestion: for now leave it as it is, when doing the next backend step move it completely to the backend code and eventually get the filename "changelog" from the config entry "cn=changelog"
ok, should have looked before. In cl5_init the name "changelog.db" is only created and used for a slapd_log_err message, which cna be made more generic.
So use #define in bdb_layer, remove it from cl5_init and ignore dbscan
Metadata Update from @lkrispen: - Custom field origin adjusted to None - Custom field reviewstatus adjusted to None
Metadata Update from @mreynolds: - Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1843522
Issue linked to Bugzilla: Bug 1843522
Metadata Update from @mreynolds: - Issue assigned to mreynolds
Metadata Update from @mreynolds: - Issue priority set to: major - Issue set to the milestone: 1.4.4
https://pagure.io/389-ds-base/pull-request/51258
Commit e8f06927 relates to this ticket
Metadata Update from @mreynolds: - Issue close_status updated to: fixed - Issue status updated to: Closed (was: Open)
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/4174
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: fixed)