#50920 cl-dump exit code is 0 even if command fails with invalid arguments
Closed: wontfix by spichugi. Opened by spichugi.

Description of problem:
When running the cl-dump.pl script with invalid arguments, the exit code is always 0, even if an error message is reported

Version-Release number of selected component (if applicable):
389-ds-base-libs-1.3.10.1-4.el7.x86_64

How reproducible:
always, with invalid arguments passed to cl-dump

Steps to Reproduce:
1-a. run dirsrvtests/tests/suites/replication/changelog_test.py::test_cldump_files_removed pytest

Or

1-b. run cl-dump with for example invalid port num

cl-dump -h localhost -p 2389 -D cn=directory\ manager -w secret12

"Can't connect to localhost:2389 as "cn=directory manager"
2-b. # echo $?
0

Actual results:
rc = 0

Expected results:
A non 0 rc code reflecting that the command couldn't be executed properly

Additional info:
We've seen that changing return for exit in cl-dump.pl cl_dump_and_decode function makes the rc be 255 ...

Cloned from https://bugzilla.redhat.com/show_bug.cgi?id=1769296


Metadata Update from @spichugi:
- Issue assigned to spichugi

https://pagure.io/389-ds-base/pull-request/50922

Metadata Update from @spichugi:
- Custom field origin adjusted to None
- Custom field reviewstatus adjusted to None

Metadata Update from @spichugi:
- Issue tagged with: Easyfix

Metadata Update from @spichugi:
- Issue close_status updated to: fixed
- Issue status updated to: Closed (was: Open)

To ssh://pagure.io/389-ds-base.git
a587d4bf6..0ba1a6c95 389-ds-base-1.3.10 -> 389-ds-base-1.3.10

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/3973

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: fixed)

Metadata