#50882 Health check tool Encryption check fails on the instance without TLS
Closed: wontfix by mreynolds. Opened by vashirov.

Issue Description

If an instance is configured without TLS, health check tool fails:

INFO: Checking Encryption ...
DEBUG: cn=encryption,cn=config getVal('sslVersionMin')
DEBUG: '<' not supported between instances of 'NoneType' and 'bytes'
Traceback (most recent call last):
  File "/usr/sbin/dsctl", line 134, in <module>
    result = args.func(inst, log, args)
  File "/usr/lib/python3.7/site-packages/lib389/cli_ctl/health.py", line 89, in health_check_run
    result = lo_inst.lint()
  File "/usr/lib/python3.7/site-packages/lib389/_mapped_object.py", line 981, in lint
    for result in fn():
  File "/usr/lib/python3.7/site-packages/lib389/config.py", line 254, in _lint_check_tls_version
    if tls_min < ensure_bytes('TLS1.1'):
TypeError: '<' not supported between instances of 'NoneType' and 'bytes'
ERROR: Error: '<' not supported between instances of 'NoneType' and 'bytes'

Package Version and Platform

389-ds-base-1.4.3.2-20200205gitfcd6b2e1c.fc31.x86_64

Steps to reproduce

from lib389.topologies import topology_m2
def test_m2(topology_m2):
    breakpoint()
# dsctl master1 healthcheck

Actual results

Enter password for cn=Directory manager on ldap://localhost:39001: 
Beginning lint report, this could take a while ...
Checking Backends ...
Checking Config ...
Checking Encryption ...
Error: '<' not supported between instances of 'NoneType' and 'bytes'

Expected results

Health check tool should not fail. And perhaps suggest to use TLS.


Metadata Update from @mreynolds:
- Issue assigned to mreynolds

https://pagure.io/389-ds-base/pull-request/50887

This also addresses https://pagure.io/389-ds-base/issue/50883

Metadata Update from @mreynolds:
- Custom field origin adjusted to None
- Custom field reviewstatus adjusted to None

Commit 827c97d9 relates to this ticket

Commit 827c97d relates to this ticket

2b6c1bb3f..319bf5d2d 389-ds-base-1.4.2 -> 389-ds-base-1.4.2

9928e5bcb..66a81301c 389-ds-base-1.4.1 -> 389-ds-base-1.4.1

Metadata Update from @mreynolds:
- Issue close_status updated to: fixed
- Issue set to the milestone: 1.4.1
- Issue status updated to: Closed (was: Open)

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/3935

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: fixed)

Metadata
Related Pull Requests