389-ds-base

#50824 dsctl remove fails with "name 'ensure_str' is not defined"
Closed: wontfix by mhonek. Opened by vashirov.

Closed: wontfix
Reopen Issue

Issue Description

# dsctl -v server-f31 remove --do-it
...
DEBUG: Removing the systemd symlink
CRITICAL: Instance removal failed

Tests from dirsrvtests/tests/suites/setup_ds/ fail with:

        # We can not assume we have systemd ...
        if dirsrv.ds_paths.with_systemd:
            # Remove the systemd symlink
            _log.debug("Removing the systemd symlink")
            result = subprocess.run(["systemctl", "disable", "dirsrv@{}".format(dirsrv.serverid)],
                                    stdout=subprocess.PIPE, stderr=subprocess.PIPE)
            args = ' '.join(ensure_list_str(result.args))
>           stdout = ensure_str(result.stdout)
E           NameError: name 'ensure_str' is not defined
/usr/lib/python3.7/site-packages/lib389/instance/remove.py:106: NameError

Package Version and Platform

389-ds-base-1.4.3.1-20200116gitfa1f69a16.fc31.x86_64

Steps to reproduce

Try to remove any instance

Actual results

Instance removal fails.

Expected results

Instance removal should be successful.

Metadata Update from @mhonek:
- Issue assigned to mhonek

Commit 4f9aafca fixes this issue

f09adba48..9d3bde5f8 389-ds-base-1.4.2 -> 389-ds-base-1.4.2

Metadata Update from @mhonek:
- Custom field origin adjusted to None
- Custom field reviewstatus adjusted to None
- Issue close_status updated to: None (was: Fixed)

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/3878

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix
Metadata
None
None
None
None
None
None
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.