I think we should be updating the global completion, it's the best solution here.

I think we should be updating the global completion, it's the best solution here.

The problem with the global policy is that we still need to update ~/.bashrc to source in the file created by activate-global-python-argcomplete, except it's much more difficult to do so in the specfile %post script, and we are still left with the issue that there is no way to undo it

Foremost, I think we cannot dare to mangle user profiles. And we shouldn't need to anyway, since AFAIU bash-completion adds bindings for sourcing completions from /etc/bash_completion.d which is the place where python-argcomplete puts its own file to be sourced. For us it should be enough to do the magic eval from the argcomplete's docs in a file we place into /etc/bash_completion.d.

Foremost, I think we cannot dare to mangle user profiles. And we shouldn't need to anyway, since AFAIU bash-completion adds bindings for sourcing completions from /etc/bash_completion.d which is the place where python-argcomplete puts its own file to be sourced. For us it should be enough to do the magic eval from the argcomplete's docs in a file we place into /etc/bash_completion.d.

activate-global-python-argcomplete does not work own its own. Trust me I spent all day trying to get it to work

On RHEL 8 this is bashrc file:

# Source global definitions
if [ -f /etc/bashrc ]; then
        . /etc/bashrc
fi

This does not read/source /etc/bash_completion.d/ I opened a new shell, etc I tried everything. We have to update .bashrc on RHEL 8. On Fedora 30 it all works without having to do anything. But apparently on F31 and RHEL 8 it requires more invasive action :-(

Okay, got it working. Needed to have bash-completion package installed, then activate-global-python-argcomplete worked. Going to put together PR next...

https://pagure.io/389-ds-base/pull-request/50760

@mreynolds Sorry, maybe I was not clear enough in my message, but (just for the record now) by stating since AFAIU bash-completion adds bindings I implied the bash-completion is required for this to work. I didn't have a strong opinion on this though, since I am OK with approach of people deciding whether to have extended bash completion (not only the readline one) that bash-completion brings, or not.

Commit 4a6a2800 relates to this ticket

@mreynolds Sorry, maybe I was not clear enough in my message, but (just for the record now) by stating since AFAIU bash-completion adds bindings I implied the bash-completion is required for this to work. I didn't have a strong opinion on this though, since I am OK with approach of people deciding whether to have extended bash completion (not only the readline one) that bash-completion brings, or not.

What threw me off was that although bash_completion was not installed, I still had /etc/bash_completions.d/ So I thought that was all set up. Anyway thanks for clarifying everything.

Commit 4a6a280 relates to this ticket

53ae89644..34c8f8570 389-ds-base-1.4.1 -> 389-ds-base-1.4.1

67b12ad54..e9e5f9731 389-ds-base-1.4.0 -> 389-ds-base-1.4.0

Commit ec229f7d relates to this ticket

8fbe97689..a9fa0add3 389-ds-base-1.4.1 -> 389-ds-base-1.4.1
e14188301..ea0af4261 389-ds-base-1.4.0 -> 389-ds-base-1.4.0

Reopening to address Fedora Minimization Objective.
bash-completion should be Recommends instead of Requires.

Commit 6fd09c43 relates to this ticket

5d162fc30..edddec50b 389-ds-base-1.4.2 -> 389-ds-base-1.4.2
22a3b1668..60818c060 389-ds-base-1.4.1 -> 389-ds-base-1.4.1

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/3813

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.