389-ds-base

#50712 Version comparison doesn't work correctly on git builds
Closed: wontfix by vashirov. Opened by vashirov.

Closed: wontfix
Reopen Issue

Issue Description

>>> get_ds_version()
'1.4.2.3.20191112git7a7bc7872'
>>> ds_is_older('1.4.0')
True

This happens because packaging.version returns a different object for '1.4.2.3.20191112git7a7bc7872' (LegacyVersion) than for '1.4.0' (Version).
And during comparison Version is always higher:

>>> x = Version('1.0')
>>> y = LegacyVersion('2.0')
>>> x > y
True

Commit 2b8750d6 fixes this issue

06096b3e8 (HEAD -> 389-ds-base-1.4.1
786a60753

Metadata Update from @mreynolds:
- Custom field origin adjusted to None
- Custom field reviewstatus adjusted to None
- Issue close_status updated to: None (was: Fixed)

Commit 6d70cbe8 fixes this issue

Commit bcf5e9f9 relates to this ticket

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/3767

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)
Metadata
None
None
None
None
None
None
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.