Ticket was cloned from Red Hat Bugzilla (product Red Hat Enterprise Linux 7): Bug 1498980
Description of problem: there's a heap corruption during import of RDS10 from RHDS9: (gdb) thread 1 [Switching to thread 1 (LWP 2403)] #0 __memcpy_ssse3 () at ../sysdeps/x86_64/multiarch/memcpy-ssse3.S:2079 2079 mov %r11, -18(%rdi) (gdb) bt #0 __memcpy_ssse3 () at ../sysdeps/x86_64/multiarch/memcpy-ssse3.S:2079 #1 0x00007f609ef69caf in memcpy (__len=18, __src=<optimized out>, __dest=0x7f602dafafff) at /usr/include/bits/string3.h:51 #2 encode (data=data@entry=0x7f602daf76d0, buf=buf@entry=0x7f602daf7710 "=0\\82'h0\\82&P\\02\\01\\010`\\a1^0\\\\\\a4Z0 X1\\0b0\\09\\06\\03U\\04\\06\\13\\02US1\\100\\0e\\06\\03U\\04\\0a\\13\\07Entrus t1\\\"0 \\06\\03U\\04\\0b\\13\\19Certification Authorities1\\130\\11\\06\\03U\\04\\0b\\13\\0aDComRootCA0h\\a0f0d0\\\\\\a4"...) at ldap/servers/slapd/back-ldbm/index.c:806 #3 0x00007f609ef6bdc7 in encoded (d=0x7f602daf76e0, d=0x7f602daf76e0, buf=0x7f602daf7710 "=0\\82'h0\\82&P\\02\\01\\010`\\a1^0\\\\\\a4Z0X1\\0b0\\0 9\\06\\03U\\04\\06\\13\\02US1\\100\\0e\\06\\03U\\04\\0a\\13\\07Entrust1\\\"0 \\06\\03U\\04\\0b\\13\\19Certification Authorities1\\130\\11\\06\\03U\\04\\0b\\13\\0aDComRootCA0h\\a0f0d0\\\\\\a4"...) at ldap/servers/slapd/back-ldbm/index.c:844 #4 addordel_values_sv (be=0x562dfdced400, db=0x562e07246c00, indextype=<optimized out>, vals=<optimized out>, id=13834, flags=<optimized out>, txn=0x34305c5533305c36, a=0x305c33315c36305c, idl_disposition=0x3030315c31535532, buffer_handle=0x305c36305c65305c, type=<optimized out>) at ldap/servers/slapd/back-ldbm/index.c:1915 #5 0x305c39305c306230 in ?? () #6 0x34305c5533305c36 in ?? () #7 0x305c33315c36305c in ?? () Version-Release number of selected component (if applicable): 389-ds-base-1.3.6.1-19.el7_4.x86_64
Metadata Update from @mreynolds: - Custom field rhbz adjusted to https://bugzilla.redhat.com/show_bug.cgi?id=1498980
Metadata Update from @mreynolds: - Issue assigned to mreynolds
Metadata Update from @mreynolds: - Custom field component adjusted to None - Custom field origin adjusted to None - Custom field reviewstatus adjusted to review - Custom field type adjusted to None - Custom field version adjusted to None
Metadata Update from @firstyear: - Custom field reviewstatus adjusted to ack (was: review)
I revised the patch to include a small performance boost. Even if trace logging was not enabled, the logging functions were still executing the encoded() function. The change I made was to check if trace logging was being used before actually calling slapi_log_err(SLAPI_LOG_TRACE, ...)
Metadata Update from @mreynolds: - Custom field reviewstatus adjusted to review (was: ack)
Ahhhh I see. Yep had a look and this is also still okay. Ack :)
Thanks for the review!
77df9a54a..b4497c4f2 master -> master
e2421d857..b4e727f77 389-ds-base-1.3.7 -> 389-ds-base-1.3.7
c81a5af21..d63858c52 389-ds-base-1.3.6 -> 389-ds-base-1.3.6
Metadata Update from @mreynolds: - Custom field reviewstatus adjusted to ack (was: review) - Issue set to the milestone: 1.3.6.0 (was: 1.3.7.0) - Issue status updated to: Closed (was: Open)
commit be4d7e5a82c1616317fa52968d2814e3f922254c
Oneline fix, only affected master. Double { was added.
And 1.3.7, 1.3.6 is good
b4e727f77..231c28bcf 389-ds-base-1.3.7 -> 389-ds-base-1.3.7
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/2500
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix