{root@ldapkdc 15:16} /opt/dirsrv/var/lib/dirsrv/slapd-localhost/db I0> sha256sum DBVERSION 
290ac0a972ed0f733833910292885ee23deef934edf2ce0789f968f3e666f57a  DBVERSION
{root@ldapkdc 15:16} /opt/dirsrv/var/lib/dirsrv/slapd-localhost/db I0> sha256sum /home/william/development/389ds/ds/DBVERSION 
290ac0a972ed0f733833910292885ee23deef934edf2ce0789f968f3e666f57a  /home/william/development/389ds/ds/DBVERSION

The supplied DBversion file matches my version, so as a result, I don't know if the issue is in dbversion_read or not. Going to ask for more info.

It seems the underlying issue is that DBVERSION in the userRoot was an empty file.

We can't avoid this happening (due to disk full), but we can display the error better, and explain recovery steps in our output.

I also noticed a lot of junk in the buffer, so we should set this to {0} too.

Affects 1.3.5, do we want to backport a fix to this @mreynolds ? It's low risk IMO.

commit 9e1a761b45dfc2d28199e39c514ea66764c3f127
To ssh://git@pagure.io/389-ds-base.git
9cd5292..9e1a761 master -> master

commit d8cccbf70e2cc8b807190214a93d20b20d77db50
To ssh://git@pagure.io/389-ds-base.git
9e1a761..d8cccbf master -> master

One line rule to correct typo.

This commit: d8cccbf does not add a "\n" to the logging line. Other logging you added is also missing "\n". And there are compiler warnings again :-(

In file included from ../389-ds-base/ldap/servers/slapd/csngen.h:20:0,
                 from ../389-ds-base/ldap/servers/slapd/slap.h:113,
                 from ../389-ds-base/ldap/servers/slapd/back-ldbm/back-ldbm.h:88,
                 from ../389-ds-base/ldap/servers/slapd/back-ldbm/dbversion.c:15:
../389-ds-base/ldap/servers/slapd/back-ldbm/dbversion.c: In function ‘dbversion_write’:
../389-ds-base/ldap/servers/slapd/back-ldbm/dbversion.c:105:21: warning: too many arguments for format [-Wformat-extra-args]
                     "Could not write to file \"%s\"\n", filename, 0, 0 );
                     ^
../389-ds-base/ldap/servers/slapd/slapi-private.h:40:81: note: in definition of macro ‘slapi_log_err’
 # define slapi_log_err(level, subsystem, ...) slapi_log_error(level, subsystem, __VA_ARGS__)
                                                                                 ^~~~~~~~~~~
../389-ds-base/ldap/servers/slapd/back-ldbm/dbversion.c:115:25: warning: too many arguments for format [-Wformat-extra-args]
                         "Could not write to file \"%s\"\n", filename, 0, 0 );
                         ^
../389-ds-base/ldap/servers/slapd/slapi-private.h:40:81: note: in definition of macro ‘slapi_log_err’
 # define slapi_log_err(level, subsystem, ...) slapi_log_error(level, subsystem, __VA_ARGS__)

Can you please follow the steps we previously discussed before putting patches out for review? Thanks

  CC       ldap/servers/slapd/back-ldbm/libback_ldbm_la-dbversion.lo
/home/william/development/389ds/ds/ldap/servers/slapd/back-ldbm/archive.c: In function ‘ldbm_back_archive2ldbm’:
/home/william/development/389ds/ds/ldap/servers/slapd/back-ldbm/archive.c:219:24: warning: declaration of ‘inst’ shadows a previous local [-Wshadow]
         ldbm_instance *inst;
                        ^~~~
/home/william/development/389ds/ds/ldap/servers/slapd/back-ldbm/archive.c:29:20: note: shadowed declaration is here
     ldbm_instance *inst = NULL;
                    ^~~~
  CC       ldap/servers/slapd/back-ldbm/libback_ldbm_la-dn2entry.lo

Only remaining warning.

Thanks! ack

commit 5d5b9c617e8c73f3771720c1f6906bddae2612db
To ssh://git@pagure.io/389-ds-base.git
066aaad..5d5b9c6 master -> master

commit 04904b61138a3bb877d535f221cfc65a5a95f335
To ssh://git@pagure.io/389-ds-base.git
bf34218..04904b6 389-ds-base-1.3.6 -> 389-ds-base-1.3.6

commit ad0855f87850351f9b5253683fae8ae8f7cc3996
To ssh://git@pagure.io/389-ds-base.git
556674c..ad0855f 389-ds-base-1.3.5 -> 389-ds-base-1.3.5

commit d46a524f49e9beca4cc6afc4498e03eb8fee595f
To ssh://git@pagure.io/389-ds-base.git
bcbc3e9..18ccdb4 master -> master

commit 6725e03187610ef852e1577f1a2745320f30b088
To ssh://git@pagure.io/389-ds-base.git
306e217..6725e03 389-ds-base-1.3.6 -> 389-ds-base-1.3.6

commit 1b4d2c63311a544bf845ae6e491ef27855f9f9c6
To ssh://git@pagure.io/389-ds-base.git
ad0855f..1b4d2c6 389-ds-base-1.3.5 -> 389-ds-base-1.3.5

Fix cherry-pick error:

1b4d2c6..88d42bb 389-ds-base-1.3.5 -> 389-ds-base-1.3.5

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/2332

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.