attachment
0001-Ticket-48964-cleanAllRUV-changelog-purging-incorrect.patch

Looks good!

f2ecfcc..fda0043 master -> master
commit fda00435a7536c1ded72bb78a975f3370d09a3be
Author: Mark Reynolds mreynolds@redhat.com
Date: Tue Aug 23 12:06:30 2016 -0400

c7fb671..792aa66 389-ds-base-1.3.4 -> 389-ds-base-1.3.4
commit 792aa66d60469a2262869680f61bb607a0e1012e

2191728..f4df06b 389-ds-base-1.3.3 -> 389-ds-base-1.3.3
commit f4df06b4d50edbf4a8e3c0a8a8ecc08a174ce870

855c34e..0d5afb2 389-ds-base-1.2.11 -> 389-ds-base-1.2.11
commit 0d5afb2bbd6d639ec59e6bdf075bd61d3d72ef79

Ticket has been cloned to Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1369570

Ticket has been cloned to Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1369572

fix regression
0001-Ticket-48964-cleanallruv-changelog-purging-removes-w.patch

Looks good to me.

81c6e66..a38d76d master -> master
commit a38d76d27970b5b6facf2ffbd1bce9d6979e6297
Author: Mark Reynolds mreynolds@redhat.com
Date: Thu Dec 22 14:38:27 2016 -0500

460c578..4053587 389-ds-base-1.3.5 -> 389-ds-base-1.3.5
commit 4053587d5dfb9c4b4e5cd966cabb1adc624511d6

262f095..7b39835 389-ds-base-1.3.4 -> 389-ds-base-1.3.4
commit 7b398351a9cfa4175b0b4c1f12b0bd6aa5ef2a09

f850128..41c0a49 389-ds-base-1.2.11 -> 389-ds-base-1.2.11
commit 41c0a49148725667fbced82b2c2be5b6ec37a4db

Hi Mark,

Covscan reported this error in the patch. Since replica is asserted as non-NULL, could you please remove the NULL check at the line 1471? Thanks.
{{{
1439 PR_ASSERT (replica);
}}}

{{{
1. Defect type: REVERSE_INULL ¶
1. 389-ds-base-1.3.5.10/ldap/servers/plugins/replication/repl5_replica_config.c:1442: deref_ptr_in_call: Dereferencing pointer "replica".
2. 389-ds-base-1.3.5.10/ldap/servers/plugins/replication/repl5_replica.c:781:2: deref_parm: Directly dereferencing parameter "r".
3. 389-ds-base-1.3.5.10/ldap/servers/plugins/replication/repl5_replica_config.c:1471: check_after_deref: Null-checking "replica" suggests that it may be null, but it has already been dereferenced on all paths leading to the check.

1469| * Now purge the changelog. The purging thread will free the purge_data

1470| */

1471|-> if (replica){

1472| purge_data = (cleanruv_purge_data*)slapi_ch_calloc(1, sizeof(cleanruv_purge_data));

1473| purge_data->cleaned_rid = rid;

}}}

Hi Mark,

The patch looks good, just a minor comment.
free_purge_data does free ''purge_data->replName'' that is the replica name (replica->repl_name).
I think it should not because the replica structure should survive from '_cl5DoPurging'.
Free of ''replGen'' is valid because it was a duplicated string.

Replying to [comment:11 tbordaz]:

Hi Mark,

The patch looks good, just a minor comment.
free_purge_data does free ''purge_data->replName'' that is the replica name (replica->repl_name).
I think it should not because the replica structure should survive from '_cl5DoPurging'.
Free of ''replGen'' is valid because it was a duplicated string.

You're right, I incorrectly thought replica_get_name() made a strdup of the name. New patch coming soon.

fix regression
0001-Ticket-48964-should-not-free-repl-name-after-purging.patch

Thanks Mark, the patch is looking good to me --> ACK

b032f71..017469a master -> master
commit 017469a1a055da03fc3fb4b34a7732611b7bd2b0
Author: Mark Reynolds mreynolds@redhat.com
Date: Wed Jan 4 09:41:38 2017 -0500

4053587..0929992 389-ds-base-1.3.5 -> 389-ds-base-1.3.5
commit 0929992503e143aaaa3cbfcafc4de170217ae0bc

7b39835..56a24df 389-ds-base-1.3.4 -> 389-ds-base-1.3.4
commit 56a24df1e33d3526297f05948c0d71a6ddf034e4

66f0aa8..d4d1072 389-ds-base-1.2.11 -> 389-ds-base-1.2.11
commit d4d10723bcea672739fe3407390caac392d1acfe

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/2023

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.