Hi Mark,

your patch looks good to me. Thank you for the create_test.py enhancement!

Only one '''REALLY MINOR''' thing.
If we are talking about PEP8, then doctrings(PEP257) should look like that:

{{{
"""Write a single test here...

Also, if you need any test suite initialization,
please, write additional fixture for that(include finalizer).
"""
}}}

not like that:
{{{
"""
Write a single test here...

Also, if you need any test suite initialization,
please, write additional fixture for that(include finalizer).
"""
}}}

Thanks,
Simon

Replying to [comment:2 spichugi]:

Hi Mark,

your patch looks good to me. Thank you for the create_test.py enhancement!

Only one '''REALLY MINOR''' thing.
If we are talking about PEP8, then doctrings(PEP257) should look like that:

{{{
"""Write a single test here...

Also, if you need any test suite initialization,
please, write additional fixture for that(include finalizer).
"""
}}}

not like that:
{{{
"""
Write a single test here...

Also, if you need any test suite initialization,
please, write additional fixture for that(include finalizer).
"""
}}}

Thanks,
Simon

Yeah that's just a personal preference of mine of to do it that way, but I will change it. Thanks!

revision
0001-Ticket-48795-Make-various-improvements-to-create_tes.patch

5601fe4..17f30c6 master -> master
commit 17f30c60cfdbd6b4f7a68f93ad0f9b6f0d8c52f5
Author: Mark Reynolds mreynolds@redhat.com
Date: Fri May 20 17:22:01 2016 -0400

d5a84c4..b69db2a 389-ds-base-1.3.4 -> 389-ds-base-1.3.4
commit b69db2aba462fa504724f933b7f70104be0e019b

42ba838..0b98840 389-ds-base-1.3.3 -> 389-ds-base-1.3.3
commit 0b98840714e39b6d31d672271537e28645c82c6a

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1855

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.