389-ds-base

#48346 log too verbose when re-acquiring expired ticket
Closed: wontfix Opened by pvoborni.

Closed: wontfix
Reopen Issue

This is based on FreeIPA ticket #5430

Proposal:

Do not log 

[31/Oct/2015:15:40:20 -0600] slapd_ldap_sasl_interactive_bind - Error: could not perform interactive bind for id [] mech [GSSAPI]: LDAP error -2 (Local error) (SASL(-1): generic failure: GSSAPI Error: Unspecified GSS failure.  Minor code may provide more information (Ticket expired)) errno 2 (No such file or directory)
[31/Oct/2015:15:40:20 -0600] slapi_ldap_bind - Error: could not perform interactive bind for id [] authentication mechanism [GSSAPI]: error -2 (Local error)
[31/Oct/2015:15:40:26 -0600] NSMMReplicationPlugin - agmt="cn=meToipa1.nwra.com" (ipa1:389): Replication bind with GSSAPI auth resumed

On default log level because everything behaves correctly.

Or something else to avoid having "Errors" in log during normal operation - users tend to think that there is some issue to solve.

Basically, looks good to me.

Very minor things...

'''ldap/servers/plugins/replication/repl5_connection.c'''

The comment line 2083: "Only log this message '''as FATAL''', if a server was down"? ;)
{{{
2083 / Only log this message if a server was down /
2084 slapi_log_error(log_level, repl_plugin_name,
}}}

'''ldap/servers/slapd/ldaputil.c'''

It'd be nice if you could separate the indentation changes from the primary fix... Could there be any other than the cosmetic changes in ldaputil.c?

Since you are trying to clean up the code... you may want to check the line 1148 in ldaputil.c... ;)
{{{
1145 if (0 == myerrno) {
1146 struct addrinfo *result = NULL;
1147 gaierr = getaddrinfo(hostname, NULL, NULL, &result);
1148 myerrno = errno;
}}}

Replying to [comment:7 nhosoi]:

Basically, looks good to me.

Very minor things...

'''ldap/servers/plugins/replication/repl5_connection.c'''

The comment line 2083: "Only log this message '''as FATAL''', if a server was down"? ;)
{{{
2083 / Only log this message if a server was down /
2084 slapi_log_error(log_level, repl_plugin_name,
}}}

New patch attached without the code cleanup. I will attach that patch for review after this is acked.

Thank you soooo much, Mark!!

a0b8f46..2fce6cb master -> master
commit 2fce6cb6f1df0000a920ff1779b2bca1f7b951e6
Author: Mark Reynolds mreynolds@redhat.com
Date: Wed Jun 15 13:19:20 2016 -0400

Code cleanup patch attached

2fce6cb..cb22bb3 master -> master
commit cb22bb3ce64f948b2361273b225a1423c1575979

Metadata Update from @mreynolds:
- Issue assigned to mreynolds
- Issue set to the milestone: 1.3.5.5

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1677

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)
Metadata
None
None
None
High
ack
IPA
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.