DSAdmin is a bit confusing terminology. In current implement of 389-DS, it exists an administration server (webserver+webapp) and admin directory server (hosting the 'o=netscaperoot' suffix). In a first approach, DSAdmin word can make think to a relation with those two components. In fact has nothing to do with adminserver/admin DS, DSadmin is a directory instance.
A other name should be chosen for this class of instances (DsInstance ?)
I suggest the name "dirsrv"
attachment 0001-Ticket-47568-Rename-DSAdmin-class.patch
I'm not sure what the python convention is, but I would prefer the object name be "dirsrv" instead of "dirSrv".
attachment 0002-Ticket-47568-Rename-DSAdmin-class.patch
git merge ticket47568 Updating 29337bd..b00258e Fast-forward lib389/init.py | 37 +++++++++++++++++++------------------ lib389/brooker.py | 77 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------- lib389/tools.py | 44 ++++++++++++++++++++++---------------------- lib389/utils.py | 10 +++++----- tests/backend_test.py | 44 +++++++++++++++++++++++++++----------------- tests/config.py | 2 +- tests/config_test.py | 24 +++++++++++++----------- tests/dsadmin_basic_test.py | 21 ++++++++++++++------- tests/dsadmin_create_remove_test.py | 28 +++++++++++++++++----------- tests/dsadmin_test.py | 78 +++++++++++++++++++++++++++++++++++++++++++++--------------------------------- tests/entry_test.py | 6 +++--- tests/replica_test.py | 48 ++++++++++++++++++++++++++++-------------------- tests/utils_test.py | 4 ++--
git push origin master Counting objects: 33, done. Delta compression using up to 4 threads. Compressing objects: 100% (17/17), done. Writing objects: 100% (17/17), 4.67 KiB, done. Total 17 (delta 15), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/lib389.git/ 29337bd..b00258e master -> master
commit b00258e00fb89121a810e2fbb2775292f7a9fe90 Author: Thierry bordaz (tbordaz) tbordaz@redhat.com Date: Wed Oct 23 14:31:24 2013 +0200
Milestone lib389 1.0 deleted
Metadata Update from @rmeggins: - Issue assigned to tbordaz
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/905
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)